Rename IR-stream related methods: #189
Merged
+204
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change encode/decode to serialize/deserialize. * Change "message" to "log event" where appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The IR stream methods in
ffi::ir_streamuse names likeencode_messagewhich is confusing when (1) we already haveencode_messagein theffinamespace and (2) the IR stream methods are really serializing/deserializing rather than encoding/decoding. In addition, in several places we usemessagewhen we really meanlog event. This PR resolves both issues.Validation performed
Validated unit tests pass.